Hi Eric, I've done a quick review of the changes and am ready to merge. First though some clarification, the old find .cmake files have entries for checking OSGDIR and OSGROOT were checked, but not in your new changes. Personally I don't have a problem with this as they aren't OSG projects anyway, but though I'd raise this flag to double check that this removal is what you intended. I can't image too many users relying on the OSG env vars this way so I don't see it as a problem.
Another item I wonder about is the use of several sets of FIND calls. Is this the direction CMake are heading? Could the use of custom macro simplify some of this? Robert. On Jan 4, 2008 1:48 PM, E. Wing <[EMAIL PROTECTED]> wrote: > Attached are a few Find modules with updates. Among other things, they > contain better support for environmental variables to pre-empt the > autodection default search path order which is very helpful for people > who do automated builds. (I recommend that the remaining modules > consider adding the same system to make things consistent and easier > for those people that want to do the automated builds.) > > The CMAKE_PREFIX_PATH has also been added to help people. I don't > recommend adding this to the other modules because it looks like CMake > agreed with my idea and will be adding the support in 2.6. So when > that ships, people will get it for free. (In the meantime, my modules > that do have it, it can be used.) > > Finally, I've submitted all of these modules to official CMake plus > more so they will be in the next version of CMake. It looks like I may > need to sort some compatibility issues out with the KDE people who > seem to have conflicting modules, but this is unrelated to the updates > submitted here as OSG already has these conflicts. I figured I would > just sync OSG up with my current/best versions. > > Also of note, I added the large batch of Findosg*.cmake modules to > CMake so people building against OpenSceneGraph can use these without > writing their own. I wasn't sure if I should submit them here or not > since they are for building against OSG and not for building OSG > itself. So they are not included. > > > Thanks, > Eric > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
