Hi Melchoir,

I can't find any record of your earlier submission w.r.t caps lock so
if it hadn't been ignored.

I have just tried to apply the patch but get a compile error

GraphicsWindowX11.cpp:1240: error: 'ev' was not declared in this scope

    _lockMask = ev.xkey.state & LockMask;

The indenting on this line is way out so it very much looks like this
done to patch not being a reliable way of patching...

Could you please post the whole files.  Whole files take me a fraction
of the time to review and avoid issues like patch inserting code in
the wrong place.

Thanks,
Robert.

On Wed, Mar 12, 2008 at 3:18 PM, Melchior FRANZ
<[EMAIL PROTECTED]> wrote:
> This bugfix probably got lost. It has been submitted more than
>  two weeks ago. Almost all patches that were submitted later
>  habe been committed already. Here again, this time as diff:
>
>
>
>  Index: include/osgViewer/api/X11/GraphicsWindowX11
>  ===================================================================
>  --- include/osgViewer/api/X11/GraphicsWindowX11 (revision 7924)
>  +++ include/osgViewer/api/X11/GraphicsWindowX11 (working copy)
>  @@ -48 +48,2 @@
>  -            _lastEventType(0)
>  +            _lastEventType(0),
>  +            _lockMask(0)
>  @@ -185,0 +187 @@
>  +        int             _lockMask;
>  Index: src/osgViewer/GraphicsWindowX11.cpp
>  ===================================================================
>  --- src/osgViewer/GraphicsWindowX11.cpp (revision 7924)
>  +++ src/osgViewer/GraphicsWindowX11.cpp (working copy)
>  @@ -714 +714 @@
>  -                                     KeymapStateMask | FocusChangeMask );
>  +                                     KeymapStateMask | FocusChangeMask | 
> EnterWindowMask );
>  @@ -1017,0 +1018,5 @@
>  +            case EnterNotify :
>  +                osg::notify(osg::INFO)<<"EnterNotify event 
> received"<<std::endl;
>  +                _lockMask = ev.xcrossing.state & LockMask;
>  +                break;
>  +
>  @@ -1172,0 +1178 @@
>  +                _lockMask = ev.xkey.state & LockMask;
>  @@ -1202 +1208,2 @@
>  -#endif
>  +#endif
>  +                _lockMask = ev.xkey.state & LockMask;
>  @@ -1315 +1322 @@
>  -    event.state = getModifierMask();
>  +    event.state = getModifierMask() | _lockMask;
>  @@ -1319 +1326 @@
>  -    int keySymbol = 0;
>  +    int keySymbol;
>  _______________________________________________
>  osg-submissions mailing list
>  [email protected]
>  
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to