Hi Jason,
Looking at the LesGeode functor in question I think the method:
bool operator() (const osg::Geode* lhs,const osg::Geode* rhs) const
{
if (lhs->getStateSet()<rhs->getStateSet()) return true;
if (lhs->getNodeMask()<rhs->getNodeMask()) return true;
return false;
}
Should be changed to:
bool operator() (const osg::Geode* lhs,const osg::Geode* rhs) const
{
if (lhs->getNodeMask()<rhs->getNodeMask()) return true;
if (lhs->getNodeMask()>rhs->getNodeMask()) return false;
return (lhs->getStateSet()<rhs->getStateSet());
}
I think the easiest way to get this tested is to check it in and then
make a call for testing on osg-users so check in what I think is
correct and go send a message to osg-users.
Robert.
On Tue, Mar 25, 2008 at 11:13 AM, Robert Osfield
<[EMAIL PROTECTED]> wrote:
> Hi Jason,
>
> Thanks for sending the file in. I've just reviewed it and find it a
> bit confusing what it's trying to achive and why. Looking at Kamil's
> post on osg-users it mentionds an insue with a functor, but its not
> entirely clear. Before I merge anything I need to get to the bottom
> of the problem, and most likely just introduce a different fix that
> will be more clear.
>
> Would it be possible to send a file that reproduces the problem and
> ideally the output of the osgconv once its imported it
> correctly/incorrectly. If there is a Windows specific issue I might
> not be able to reproduce it so the different versions of outputted
> .osg files will enable me to get more inside what's happening.
>
> Thanks,
> Robert.
>
>
>
> On Thu, Mar 20, 2008 at 3:43 PM, Jason Daly <[EMAIL PROTECTED]> wrote:
> >
> > This is the fix for crashes in the OpenFlight loader that Kamil Krupa
> > sent to osg-users earlier. It doesn't seem like he's going to resubmit
> > it, and I just want to make sure it makes it into the next release, as
> > it fixes a big problem for me.
> >
> > Of course, credit should go to Kamil, and not to me.
> >
> > --
> >
> > --"J"
> >
> > "I'm a castaway stranded in a desolate land,
> > I can see the footprints in the virtual sand."
> > --Neil Peart
> >
> >
> > _______________________________________________
> > osg-submissions mailing list
> > [email protected]
> >
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
> >
> >
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
