Hi Bob, I think perhaps osgViewer itself needs to be tweaked so that either --stencil enable the camera clear automatically, or that it checks of --stencil-clear. The clear value is something you might also want to pass in. Could you explain what problem you came across that you are trying to address with this change, this will help inform where the best place for the changes to go.
You changes retain the dummy Group which is redundant and misleading now that the Camera's clear methods are used correctly, luckily I review changes otherwise stuff like this would just degrade software quality over time. Cheers, Robert. On Mon, Aug 25, 2008 at 1:39 PM, Bob Kuehne <[EMAIL PROTECTED]> wrote: > there is a distinct difference between requesting a visual which has stencil > bits, and actually clearing those bits. since i know you must already know > this, i gather, then, that you're suggesting a different implementation > approach. > > yes, i've used the '--stencil' option, and no, it doesn't clear the buffer. > > so, it's true, i didn't think of the redundant clear operations in camera to > implement this. so as you're implying that's preferred, here's the same > code, re-factored to use the Camera clear settings, and not the ClearNode > clear settings. if you're rejecting this idea based on some other principle, > please explain further. > > bob > > > On Aug 25, 2008, at 8:15 AM, Robert Osfield wrote: > >> Hi Bob, >> >> This submission looks like you aren't aware of the DisplaySettings >> command line parsing that is done in the >> osgViewer::Viewer(ArgumentParser&) constructor. To get the command >> line docs on this simple do: >> >> osgviewer --help | grep stencil >> >> And you'll see: >> >> --stencil Request a stencil buffer >> visual >> >> This hints to the Viewer to create a frame buffer with a stencil >> buffer. You also note that the osg::Camera has a range of stencil >> buffer clear methods, so using a ClearNode is not required - you can >> simple set what is required via the viewers Camera(s). >> >> Robert. >> >> On Mon, Aug 18, 2008 at 3:26 PM, Bob Kuehne <[EMAIL PROTECTED]> wrote: >>> >>> added option to enable stencil clear in osgviewer. >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>> >>> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
