On Wed, 2008-09-17 at 17:46 +0100, Robert Osfield wrote: > Hi Max & Jeremy, > > I've gone ahead and made the suggested change and check it into svn > trunk. I'll let Jeremy decide what to do on his osgWidget branch (he > may well of fixed the associated code).
Yeah, I already had it. However, it's such a serious bug it's worth going into trunk ASAP too. :) How I introduced this silly bug, I'll never know... > In future Max could you send the whole modified file rather than a > just a code suggestion, as I do graphical diffs against changes as > it's the most full proof way of merging the actual fix without > mistakes, doing copy and paste or own interpretations of fixes leaves > us open to introducing other bugs accidentally. > > Thanks, > Robert. > > On Tue, Aug 26, 2008 at 5:08 PM, Max Bandazian <[EMAIL PROTECTED]> wrote: > > Hi, > > > > Lines 302-305 of WindowManager.cpp seem to have a parenthesizing error - the > > code is > > if( > > (!win || win->getVisibilityMode() == Window::VM_PARTIAL) && > > !win->isPointerXYWithinVisible(x, y) > > ) continue; > > > > But it probably should be > > > > if (!win || (win->getVisibilityMode() == Window::VM_PARTIAL) && > > !win->isPointerXYWithinVisible(x, y))) > > continue; > > > > The effect of the bug is to segfault if a non-osgWidgets::Window node hasn't > > been excluded from picking via NodeMask. > > > > On a related note, it would be nice if in some future version it were > > possible to do widget picking through a camera other than the master, since > > a slave camera seems like a convenient way to view a HUD. > > > > Thanks, > > Max Bandazian > > > > _______________________________________________ > > osg-submissions mailing list > > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
