Thanks Mattias, I have now merged and submitted to SVN your changes to CMakeLists.txt and OsgMacroUtils.cmake. Fingers crossed they won't break any of the build combinations. Things work fine in my my testing under Kubuntu7.10 with CMake 2.6.1. Cheers, Robert.
On Tue, Aug 26, 2008 at 3:17 PM, Mattias Helsing <[EMAIL PROTECTED]> wrote: > Hello Robert, all, > > ok, back on the submission list after a shortcut through osg-users. > > On Philips suggestion truncated a redundant if/else construction in > OsgMacroUtils to avoid developer warnings in cmake-2.6.1 concerning > cmake policy CMP0008 which allows full paths to libraries only with > valid library names > > cheers > Mattias > > On 8/26/08, Mattias Helsing <[EMAIL PROTECTED]> wrote: >> Hi Robert, all, >> >> yes, I agree. Philip's suggestion will replace x confusing lines of cmake >> code which is good but will need testing on msvc 7.1 through 9.0 with cmake >> 2.4.7 through 2.6.1. The nmake builds have already been tested so nmake >> seems ok. I will test what configurations i can but am a bit swamped on my >> real job, so will take a day or two. >> >> However - should users start using/complaining about cmake dev-warnings with >> cmake-2.6.1 my initial submission is safe (the change will be there in >> coming submission with OLD replaces by NEW in "policy CMP0008 [OLD|NEW]") >> >> cheers >> Mattias >> >> On Mon, Aug 25, 2008 at 4:31 PM, Robert Osfield >> <[EMAIL PROTECTED]>wrote: >> >>> Hi Guys, >>> >>> I'm poised to review the original changes posted by , but Mattias, but >>> subsequent discussion sugets that that we could possible could go >>> further/there are other problems still needing resolving. I'm no >>> Windows users, nor one of the original authors of our CMake system so >>> simply don't have enough of insight to be be a final judgement on what >>> should be changed, so I believe it would be appropriate to open the >>> discussion out wider on osg-users, and in the context of new CMake >>> versions and the various Windows centric revisions that have been made >>> to our build system. The online svn browser might help here. >>> >>> Thoughts? >>> Robert. >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>> >> > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
