Hi Robert, On Wednesday 17 September 2008 17:51, Robert Osfield wrote: > Sorry for the slow review, been busy with VPB and volume rendering > these last two weeks, just niw surfacing for air... No problem!
> I've reviewing all your changes and they look sounds and are almost > all merged as is. The use of include<limits> and associated does make > me a little concerned about compile under MipsPro as a vaguely recall > problems with some elements of the std library, I've merged regardless > of this concern as you are one of the best placed people to test this > out as you are amoungst the few that retain IRIX boxes. So could you > specific test this. The limits header is not a problem. What is missing is cstdio, cstdlic, cassert, cstring ... As fas as I know everything that starts with c ... But I double checked that it compiles on our irix machine ... ... except the next submission fixing some different problem with the irix compiler in a seperate mail :) Anyway, we still have such a machine available. But since a few weeks it is clear that we will discontinue support for our vizualization product on irix. So I can still help testing, but there is one less serious user on irix now ... > I run all the examples and so far they all seem to be working just > fine, so fingers crossed no new bugs have been introduced, we'll the > community to test it out for a while before we can be sure. Well, I used that patch on flightgear for some months before we even started to talk about that on the list. So, this is in no way full test case coverage, but some more test cases ... The Matrix methods as such should be ok due to the unit test I hope ... > Many thanks for these optimizations, Thanks for your work! Greetings Mathias -- Dr. Mathias Fröhlich, science + computing ag, Software Solutions Hagellocher Weg 71-75, D-72070 Tuebingen, Germany Phone: +49 7071 9457-268, Fax: +49 7071 9457-511 -- Vorstand/Board of Management: Dr. Bernd Finkbeiner, Dr. Florian Geyer, Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech Vorsitzender des Aufsichtsrats/ Chairman of the Supervisory Board: Prof. Dr. Hanns Ruder Sitz/Registered Office: Tuebingen Registergericht/Registration Court: Stuttgart Registernummer/Commercial Register No.: HRB 382196 _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
