Hi Robert

Thanks for merging my changes. I agree this doesn't solve the issue but
I was trying to minimize the impact to other classes that rely on the
way that the animation time is calculated currently. The main reason for
not merging my changes into the base class was that some of the plugins
write out the instance variables from the AnimationPathCallback class
and I didn't want to break the file format of osg. Plus other animation
toolkits may rely on the way animation time is currently calculated.

However, I have enclosed the subclass called
StepableAnimationPathCallback for you to evaluate whether you would like
to merge this into the base class or keep it as a separate mechanism for
people to use.

Thanks for all your hard work on OSG to make it the best product
available to meet everyones diverse needs.

Alan Dickinson
SAIC Intelligent Systems Applications Division
Sr. Software Engineer

-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
Robert Osfield
Sent: Thursday, September 18, 2008 6:52 AM
To: OpenSceneGraph Submissions
Subject: Re: [osg-submissions] AnimationPathCallback virtual methods

Hi Alan,

I have merged your changes, but I can't help feel that it doesn't do
much to actually solve the bug, and if you've actually got a solution
then it would be helpful alround to get this merged rather than have a
fix done in a subclass in one developers code base.

What did you do at your end to fix things?

Robert.


On Fri, Sep 12, 2008 at 8:36 PM, Dickinson, Alan J.
<[EMAIL PROTECTED]> wrote:
> I have changed a couple of the methods in the AnimationPathCallback
class to
> be virtual to allow me to override the animation time calculation
method
> based on the discussion I had with you and Ulrich on the users
forum(see
> below).
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegr
aph.org

Attachment: StepableAnimationPathCallback.h
Description: StepableAnimationPathCallback.h

Attachment: StepableAnimationPathCallback.cpp
Description: StepableAnimationPathCallback.cpp

_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to