Hi Robert, I am curious if you remember about this submission. It was just sent before one of my Shadow submissions and just before latest OSG release so I suspect that it could have slipped through. I am asking not because I especially want this to be added but I feel responsible for these changes and I would like to close this subject once and for all.
Cheers, Wojtek -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Wojciech Lewandowski Sent: Monday, October 06, 2008 1:17 AM To: OpenSceneGraph Submissions Subject: Re: [osg-submissions] Right time toremoverepeatingmakeCurrentContext workaround ? Robert, I have modified CMakeLists.txt to generate OSG_MULTIMONITOR_MULTITHREAD_WIN32_NVIDIA_WORKAROUND in osg/Config. This macro is checked in GraphicsWin32 and workaround gets applied accordingly. By default it is set to OFF (#undef) so the the redundant makeCurrentContext calls are not executed. I suspect that you may want to revert this logic and set default to ON. I have found that I also had to modify Config.in otherwise OSG_MULTIMONITOR_MULTITHREAD_WIN32_NVIDIA_WORKAROUND was not generated in osg/Config even though it was selected in CMake GUI. I hope it will work on other platforms. I have checked this on VS 2008 Express & Cmake 2.6 patch 1. Cheers, Wojtek -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Robert Osfield Sent: Saturday, October 04, 2008 11:02 AM To: OpenSceneGraph Submissions Subject: Re: [osg-submissions] Right time to removerepeatingmakeCurrentContext workaround ? Hi Guys, Using a CMake option would be a reasonable thing to do. Paul Martz's workaround to problems with occlussion query would be a good example to follow. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph. org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
