Hi Wojtek, I've reviewed the changes and they look like a sensible best of both worlds solution. Changes now merged and submitted to svn.
Robert. On Mon, Nov 24, 2008 at 3:23 PM, Wojciech Lewandowski <[EMAIL PROTECTED]> wrote: > Hi Robert, > > I have restored MSVC disabled warnings in osg/Export. Difference is they are > now disabled only when OSG_DISABLE_MSVC_WARNINGS macro is defined. This > macro is set through CMake options and autogenerated in osg/Config. Simon > suggested that it would be cool if we had more control over selected > warnings. I tried to learn how to make selection of individual warning > numbers possible, but had to gave up as my cmake skills were not sufficient. > The only way I saw this possible would be adding one define for each MSVC > warning number. But many definitions seemed too be to much clutter for > osg/Config file so I rejected thar idea. For this it would be cool if > autogenerated Config entries could more powerful than simple #define/#undef > flags. Maybe Cmake gurus know how to do it. > > I have not reverted added Compiler options. I assume that one may want to > have warnings enabled for the application but may not want to see them while > OSG libraries and examples compile. > > Modified files: > > osg/Export - now explicitly includes osg/Config to make sure > OSG_DISABLE_MSVC_WARNINGS is read > osg/Config.in - declares OSG_DISABLE_MSVC_WARNINGS flag to be added to > autogenerated osg/Config > CMakeLists.txt - declares OSG_DISABLE_MSVC_WARNINGS as option with default > ON setting > > Cheers, > Wojtek > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
