Thanks Alberto, sorry that you had to consume your time on this. Your efforts are appreciate though :-)
Note for Ferdi, I merged your changes to include/osg/Uniform and src/osg/Uniform.cpp, these are now checked into svn/trunk. I did not ,erge the changes to the .osg plugin as the changes were rather awkward and difficult to follow, and therefore more liable to bugs and problems in maintenance, I refactored the original code myself which should add support for "unsigned int" whilst keeping the code a bit more readable. Cheers, Robert. On Tue, Nov 25, 2008 at 11:18 AM, Alberto Luaces <[EMAIL PROTECTED]> wrote: > Robert, > > I think I have managed to get the files from Ferdi's patch. > > Alberto > > El Martes 25 Noviembre 2008ES 11:47:39 Robert Osfield escribió: >> Hi Ferdi, >> >> Third attempt now... Please could send the whole file, the rest of the >> 350 OSG contributors are able to do it. >> >> Robert. >> >> ---------- Forwarded message ---------- >> From: Robert Osfield <[EMAIL PROTECTED]> >> Date: Mon, Nov 24, 2008 at 10:15 AM >> Subject: Re: [osg-submissions] unsigned uniform support patch >> To: OpenSceneGraph Submissions <[email protected]> >> >> >> Hi Ferdi, >> >> Ping... still haven't seen whole modified files. For details of the >> submissions protocol please read. >> >> >> http://www.openscenegraph.org/projects/osg/wiki/MailingLists/SubmissionsPro >>tocol >> >> Thanks, >> Robert. >> >> On Fri, Nov 21, 2008 at 10:28 AM, Robert Osfield >> >> <[EMAIL PROTECTED]> wrote: >> > Hi Ferdi, >> > >> > Could you post the whole modified files rather than a patch. >> > >> > Thanks, >> > Robert. >> > >> > On Sat, Nov 15, 2008 at 4:25 PM, Ferdi Smit <[EMAIL PROTECTED]> wrote: >> >> I attached a small patch to add support for unsigned typed uniform >> >> variables. In particular, uniform unsigned int, uniform uvec2, uniform >> >> uvec3, uniform uvec4. These uniform variables can now be set with >> >> osg::Uniform("name", unsigned int(42)), and so on. Previously, >> >> osg::Uniform only supported "float" and "int", this adds support for >> >> "unsigned int". Because of the double-token typename, some minor changes >> >> to the .osg writer plugin for uniform were also required. Relies on >> >> gpu_shader4 and glUniform[n]uivEXT >> >> >> >> I did some simple tests using a uniform unsigned in a shader, writing it >> >> to an .osg file, and loading it again. All worked fine. Possible issues >> >> may potentially arise for existing software using unsigned int C++ types >> >> to set (signed) uniform int types, due to the new overload. I haven't >> >> noticed this yet, though. >> >> >> >> -- >> >> Regards, >> >> >> >> Ferdi Smit >> >> Email: [EMAIL PROTECTED] >> >> Room: C0.07 Phone: 4229 >> >> INS3 Visualization and 3D Interfaces >> >> CWI Amsterdam, The Netherlands >> >> >> >> >> >> _______________________________________________ >> >> osg-submissions mailing list >> >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegr >> >>aph.org >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph >>.org > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
