HI Cedric, Yes thank makes more sense. So the example should really do the check.
Robert. On Thu, Jan 8, 2009 at 4:36 PM, Cedric Pinson <[email protected]> wrote: > Hi Robert, > > In fact i am agree with you it should not crash, but on this example the > problem was in the example > > osgAnimation::AnimationUpdateCallback* cb = > dynamic_cast<osgAnimation::AnimationUpdateCallback*>(right0->getUpdateCallback()); > cb->setName("xxx"); > > So in this case it can only crash without check in the example. The crash > cames from the example not the inside osgAnimation. > Does it make more sense to you ? > > Cheers, > Cedric > > Robert Osfield wrote: >> >> Thanks Cedric, fix now merged and submitted to svn. >> >> The fact the code was crash is concerning as it could mean that user >> code that doesn't set the callback will fall afoul of the same problem >> without any particular clues to what the cause of the crash is. I >> makes me feel that class design isn't yet hanging nicely together - >> they should work with default settings, even if they can't work fully >> with configuration they surely shouldn't crash. >> >> Robert. >> >> On Thu, Jan 8, 2009 at 2:31 PM, Cedric Pinson <[email protected]> >> wrote: >> >>> >>> Hi Robert, >>> >>> Here the updated osganimationskinning.cpp that works as before >>> >>> Cheers, >>> Cedric >>> >>> -- >>> +33 (0) 6 63 20 03 56 Cedric Pinson mailto:[email protected] >>> http://www.plopbyte.net >>> >>> >>> >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>> >>> >>> >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > > -- > +33 (0) 6 63 20 03 56 Cedric Pinson mailto:[email protected] > http://www.plopbyte.net > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
