Hi Mattias,

One small comment, and I'm not sure if this is just an omission or if
it's as designed, but when unpacking the files, I get an
OpenSceneGraph-2.7 directory instead of OpenSceneGraph-2.7.9 (note the
missing .9 - the tarballs are
libopenscenegraph-2.7.9-win32-x86-vc80-RelWithDebInfo.tar.gz etc.). Is
this normal?

It's normal and designed this way. Though I have no preference in this
case so this can easily be changed. There are pros and cons of both.
If you prefer one over the other I'll fix it to your liking. Others
might have opinions here too.

Yes, I'd like to hear others on this too. I don't have a preference either, other than if we don't have a good reason to remove a number, why not keep it? That way we can differentiate between versions up to the last number. I guess I was just "expecting" the full version number to be there, so I was surprised to see OpenSceneGraph-2.7...

Also, the OpenThreads packages got unzipped to OpenSceneGraph-2.7 as
well (and not OpenThreads-x.y.z), though I think that's as designed
since we want them to land in the same place as OSG so we don't have to
add two sets of lib/include files to our projects, plus OpenThreads
lives inside OSG for all intents and purposes, right? It might be
slightly confusing to new users to have separate packages with the
intent that you absolutely need both in all cases, but it follows our
conventions.

I hadn't thought of that so thanks for asking. I would say that
openthreads should go to OpenThreads-2.7[.8] but some people might
prefer to have it all in one dir.

Not sure, I'd like others' opinions on this too.

Maybe there's a step we're missing.
What about users that want files installed in /usr/local for example.
Do we need to provide an install script or similar? I will eventually
get to looking att the debian package generator but that won't happen
before osg-2.8.

I don't think an install script is necessary (but my argument for that is the same as my argument for not using installers on Windows, I defer to others for the final word on the matter).

Debian packages will be really nice though.

These were just two things I noticed, and they're details IMHO, so I think that shows that the rest is top-notch. I was able to build the Package ALL target fine. Previous versions would fail on 2-3 of the 5-6 targets if building Package ALL, because VS tried to build several at once and then failed to lock the directories for one since it was writing another package at the same time in the same directory, this problem is not there anymore.

Thanks,

J-S
--
______________________________________________________
Jean-Sebastien Guay    [email protected]
                               http://www.cm-labs.com/
                        http://whitestar02.webhop.org/
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to