Thanks Mattias, changes now merged and submitted to SVN. The separate OsgDetermineCompiler.cmake file is fine by me. Cheers, Robert.
On Fri, Jan 16, 2009 at 11:35 AM, Mattias Helsing <[email protected]> wrote: > Hi Robert, > > I got some feedback from J-S on the packaging so I have changed the > name of the top folder in each package to OpenSceneGraph-x.y.z > > Noone else has had an opinion on whether compiler and it's version > should be part of the package filename on their platform/setup so I'll > leave it as is. That is - No action is taken for compilers other than > msvc but one can easily add this information to the cmake cache > regardless of platform. > > The submissions includes a new file OsgDetermineCompiler.cmake. You > may prefer to have this as a macro in the already existing > OsgCPack.cmake. Of so - just tell me and I'll fix and resubmit. > > cheers > Mattias > > On 1/14/09, Mattias Helsing <[email protected]> wrote: >> Hi all >> >> This submission includes: >> *proper detection of sp1 or not for the msvc80 compiler. Detection is >> placed in it's own script and only run if OSG_CPACK_COMPILER is >> undefined (deleted from cache). This also fixes J-S earlier problem of >> not being able to set this through -DOSG_CPACK_COMPILER=vc80xxx >> >> * Fixed two problems where the script didn't work for the nmake >> generator => nmake is tested to work >> >> * Improved comments in CMakeLists.txt and OsgCPack and simplified OsgCPack >> >> * indicate static builds in the package filename >> >> * It previously looked on commandline like OpenScenegraph-2.x.tar.gz >> was generated over and over. So I added a printout stating the >> OpenScenegraph-2.x is renamed to <proper_package_name>.tar.gz. This >> solution was necessary to get similar directory names >> (OpenSceneGraph-2.x) in the packages >> >> Mattias >> > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
