Hi Ragnar, On further review it looks like to me the
if (numRead<10) && if (numRead<6 lines should be rewritten numRead<1 in both cases rather than swap the fread parameters. Thoughts? Robert. On Thu, Feb 19, 2009 at 5:11 PM, Robert Osfield <[email protected]> wrote: > Hi Ragnar, could you provide an example image that reproduces the > problems so that I can confirm the bug and then confirm that the fix > addresses it. Thanks. Robert. > > On Wed, Feb 18, 2009 at 12:01 PM, Ragnar Hammarqvist > <[email protected]> wrote: >> The file src\osgPlugins\hdr\hdrloader.cpp is faulty and not working in the >> new release 2.8.0 of OSG. >> This results in .HDR images not working in OSG2.8.0. >> >> There has been some fault checks introducted such as "if (numRead<10) return >> false;" in for example isHDRFile(). The problem is that the fread() function >> call has always had its size and count arguments switched so that it in the >> above case has size=10 and count=1. This will result in a numRead=1 and not >> 10 as the check wants it to be. >> >> The bug is solved by simply switching the size and count arguments of the >> fread() calls in the hdrloader.cpp file. A corrected file is attached. >> >> Regards >> Ragnar Hammarqvist >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
