Hi, I'm all behind this patch. Much more readable/maintainable IMO.
Requiring 2.4.4 should be ok. Those who disagree should SHOUT NOW. >From what I remember 2.4.5 is the critical limit as it's what's in Debian etch and RHEL 5. see http://www.mail-archive.com/[email protected]/msg20294.html Mattias On 3/9/09, Philip Lowman <[email protected]> wrote: > At a cost of bumping the required version to CMake 2.4.4 (released all the > way back on November 21, 2006)... this cmake script patch > > 1. Makes IF/ELSE/ENDIF code blocks easier to read by replacing code like > this: > > IF(FOO) > MESSAGE("FOO is true") > ELSE(FOO) > MESSAGE(" ??? ELSE(FOO)??? ") > ENDIF(FOO) > > with this: > > IF(FOO) > MESSAGE("FOO is true") > ELSE() > MESSAGE("FOO is clearly false") > ENDIF() > > 2. Also adds an ELSEIF() where it makes sense to do so (safe to use as of > CMake 2.4.4) > > > -- > Philip Lowman > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
