Thanks Santosh, changes look like a good improvement w.r.t robustness and getting rid of warning, changes now merged and submitted to svn/trunk, thanks :-)
On Sun, Apr 12, 2009 at 4:41 PM, Santosh <[email protected]> wrote: > Hi Robert > > I have added the exception handling in ply loader. All exceptions I am > catching in VertexData::readPlyFile() and made sure that application will > not crash or exit if any exception occurred. I am returning NULL from > VertexData::readPlyFile() > if any exception occurred. > > Attached are updated files. > > Cheers > Santosh > > > > Robert Osfield wrote: > > On Thu, Apr 9, 2009 at 10:18 PM, Santosh <[email protected]> wrote: > >> Hi Robert >> >> Attached is the updated ply.h and plyfile.cpp in which I resolved the >> warnings of vertexData.cpp.() >> > > Thanks changes now merged and submitted to snv/trunk. > > > >> >> On my system I didn't got the warnings of fread() in plyfile.cpp so I >> couldn't fix those warnings. >> >> I compiled with gcc version 4.2.1. I think these warnings are getting due >> to some standard include file need to be included explicitly in particular >> OS or gcc version. >> > > The error is down to the result from fread not being used at all. This > highlights the fact that the code doesn't have any proper error detection > mechanism - it's just ignoring problems such as file errors. A quick review > of the code shows that the is an exit() in there, something which is really > bad news for live code, it would be far better to throw an exception and > catch this in the ReaderWriterPLY.cpp. > > I'm not too familiar with this code base yet so could you have a look at > adding checks into the fread operations that fix the warning and provide a > error mechanism that provides the plugin with an graceful recrovery from > error. > > Thanks, > Robert. > > > > > ------------------------------ > > _______________________________________________ > osg-submissions mailing > [email protected]http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > _______________________________________________ > osg-submissions mailing list > [email protected] > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
