Thank You, Wojtek
----- Original Message -----
From: "Robert Osfield" <[email protected]>
To: "OpenSceneGraph Submissions" <[email protected]>
Sent: Friday, May 08, 2009 2:53 PM
Subject: Re: [osg-submissions] Bug in near plane computations
Hi Wojtek,
On Fri, May 8, 2009 at 12:23 PM, Wojciech Lewandowski
<[email protected]> wrote:
Thanks Robert,
It works for me. I will do more testing later today. I will let you know
if
I find some problem.
I have one bit nosy question though. It looks like Polytope::contains
methods always initialize _resultMask to parent clipping mask
(_maskStack.back() ) and then compute updated clipping result for
child node/drawable. If its true, then resultMask for a child is always
smaller or equal to resultMask of parent. So it looks like condition:
if ( frustum.getCurrentMask() && frustum.getResultMask() )
in CullVisitor.cpp updateCalculatedNearFar line 607 is bit redundant and
could be replaced with simpler check:
if ( frustum.getResultMask() )
Am I right ? I suppose that former construct was somehow caused by the bug
we just fixed.
I believe your analysis is correct and the ResultsMask is the same or
less than CurrentMask. I've checked your suggested revision to
svn/trunk. Testing doesn't suggest any problems.
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
