Hi Chris, On Wed, May 13, 2009 at 7:08 PM, Chris 'Xenon' Hanson <[email protected]> wrote: > I grabbed your updates. The change to System.cpp:465: > > < return acceptedTypeMask & fileTypeMask; >> return (acceptedTypeMask & fileTypeMask) ? true : false; > > Cast-forcing a non-bool to a bool is something VC++ 2005 warns is an issue. > Do you > prefer not to change this? I guess we could just disable the warning, but > that might mask > issues elsewhere.
I didn't merge this particular change as it doesn't really address the issue, it just hides the warning, as the conditional hasn't changed in any way. I dislike hacks like this that just work around warnings without actually addressing what the warning is suggesting. A better solution to avoid any ambiguity is to explicitly do a comparison: return (acceptedTypeMask & fileTypeMask)!=0; This change is now checked into svn/tunk. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
