HI Johan,
I'm just doing a review of your changes relative to svn/trunk and
concerned about the comment:
// GvdB: transparent objects do not write depth
The lines of code are:
if (image->isImageTranslucent())
{
osg_stateset->setMode(GL_BLEND, osg::StateAttribute::ON);
osg_stateset->setAttribute(new osg::Depth(osg::Depth::LESS,
0.0, 1.0, false)); // GvdB: transparent objects do not write depth
osg_stateset->setRenderingHint(osg::StateSet::TRANSPARENT_BIN);
}
Normally transparent objects do not disable depth write. Could you
please explain why you've done this as it would seem like something
that is very model specific not a general feature that you'd enable.
Robert.
On Thu, May 28, 2009 at 3:35 PM, Johan
Nouvel<[email protected]> wrote:
> Hi Robert,
>
> My osg version is 2.8.0. But these bugs are also in version 2.9.5 ("svn up"
> this morning).
> In this mail I join you the corrected 2.9.5 ReaderWriterVRML2.cpp. Previous
> attachment was for osg 2.8.0.
>
> I have done tests with osg 2.8.0 only, I don't have a compiled osg 2.9.5,
> but these are local minor modifications, it should be ok in osg 2.9.5 too.
>
> Cheers,
> Johan.
>
> Robert Osfield wrote:
>>
>> Hi Johan,
>>
>> Before I dive in a review your changes, are you aware that Jan Ciger
>> has recently updated this plugin to work with the latest OpenVRML? I
>> checked Jan's changes in earlier this week into svn/trunk.
>>
>> Which version of the OSG did you make your changes against?
>>
>> Robert.
>>
>> On Thu, May 28, 2009 at 3:03 PM, Johan Nouvel
>> <[email protected]> wrote:
>>>
>>> Hello,
>>>
>>> Some fixes in the ReaderWriterVRML :
>>> 1- If image as transparency channel, set rendering hint to
>>> TRANSPARENT_BIN.
>>> It was done only if material has transparency, so with default material
>>> and
>>> rgba texture, objects where rendered in OPAQUE_BIN.
>>> 2- Copy/paste bug, repeatT vrml flag now set WRAP_T osg flag, previous
>>> was
>>> WRAP_S.
>>>
>>> Cheers,
>>>
>>> Johan.
>>> --
>>> Johan Nouvel, R&D Engineer
>>> http://www.archivideo.com
>>> tel : +33 (0)2 99 86 30 20
>>> ARCHIVIDEO, 40 rue des Veyettes, 35000 RENNES, FRANCE
>>>
>>> _______________________________________________
>>> osg-submissions mailing list
>>> [email protected]
>>>
>>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>>>
>>>
>> _______________________________________________
>> osg-submissions mailing list
>> [email protected]
>>
>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
> --
> Johan Nouvel, R&D Engineer
> http://www.archivideo.com
> tel : +33 (0)2 99 86 30 20
> ARCHIVIDEO, 40 rue des Veyettes, 35000 RENNES, FRANCE
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
