Thanks Paul, I've now merged and submitted your change to svn/trunk and the OSG-2.8 branch.
I've also added a set of other improvements to the svn/trunk version of the ITK code path in ReaderWriterDICOM.cpp so it's now able to load whole directories of dicom files and build a single 3D image from it - in the same way that the main DCMTK code path in this plugin has done it previously. This changes are just part of svn/trunk though. Cheers, Robert. On Thu, Jul 2, 2009 at 1:23 PM, Paul Fotheringham<[email protected]> wrote: > Woops, I just found the submissions guidelines. Here's the full file. Sorry. > > Paul > > --- On Thu, 2/7/09, Paul Fotheringham <[email protected]> wrote: > >> From: Paul Fotheringham <[email protected]> >> Subject: [osg-submissions] dicom plugin Linux build fix when using itk >> To: [email protected] >> Date: Thursday, 2 July, 2009, 1:06 PM >> Hi, >> >> Recently there was a thread about compile errors for the >> dicom plug-in when it was built against itk and these were >> proven to be a result of aggressive warnings/errors by gcc. >> >> I just tried to build 2.8.2rc2 and got the same build >> errors myself so I had a quick look at the itk code. It >> seems that all that is required is to define >> VCL_CAN_STATIC_CONST_INIT_FLOAT to be zero. >> >> I have attached a patch file for the CMakeLists.txt file >> for the dicom plugin. It doesn't test for platform/compiler >> but then setting that define to zero shouldn't be a problem >> on any other platform/compiler AFAIK so may as well be >> consistent. >> >> Paul Fotheringham. >> >> PS. My first ever patch so hopefully it works! >> >> >> >> >> -----Inline Attachment Follows----- >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
