Hi Paul, On Wed, Nov 11, 2009 at 7:28 PM, Paul Martz <[email protected]> wrote: > Hi Robert -- Once more, this time with feeling. :-) See attached. This is > primarily the GraphicsContextWin32 changes, but also includes the Win32 > export declaration required to make Traits accessible to DisplaySettings in > osgUtil.
Thanks changes now merged. > I wanted to ask you about your change to how I had coded the getenv support > for context flags and profile. Your code expects users to use integer > constants rather than text, e.g., > export OSG_GL_CONTEXT_FLAGS=2 > > as opposed to how I had submitted it, more like: > export OSG_GL_CONTEXT_FLAGS=FORWARD_COMPATIBLE > > Was there a reason you decided to break with how this is done in existing > OSG code like the Optimizer, for example. I option to just use the numeric values for simplicity of implementation, and flexibility of applying new values. One thing we could do is add support for parsing the keyword versions into DisplaySettings to give us back the original behaviour, whilst retain the ability to handle users passing in int's. > I also wanted to point out that your change precludes an app setting the > environment variable with a putenv call, as (on Win32 at least), the > DisplaySettings::readEnvironmentalVariables gets executed at DLL load time, > before application main() gets to execute. putenv was supported in my > original submission, so I wanted to make sure this was a conscious and > intentional change on your part. Curious, I wasn't aware of this bahaviour under Windows, and am still a bit surprised by this. osg::DisplaySettings::instance() has to be called before the singleton is created as the static variable is the local scope of the instance() method. Is there a global somewhere be constructed that is calling DisplaySettings::instance()? Robert _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
