Hi Lee, Apologies for the delay, I've finally got to reviewing your submissions and have merged it with only the change of the name of the variable/option from "noSmoothing" to "generateFacetNormals" as I felt that this is a more accurate description of what this mode does.
This nature of this submissions also opens the question as to whether we should generate any normals by default for models that have none - should we just leave them without normals, or should we leave what we have as the default and add a "noSmoothing" option that suppresses the generation of any normals. Thoughts? Robert. On Wed, Jun 3, 2009 at 6:18 PM, Butler, Lee Mr CIV USA USAMC <[email protected]> wrote: > file: src/osgPlugins/obj/ReaderWriterOBJ.cpp Release 2.8.1 > > The attached ZIP file contains a modified OBJ file format reader which > makes smoothing optional for verticies which do not have a normal > associated with them in the OBJ input file. The previous behavior was > to always smooth at all verticies which did not have surface normals. > In this new implementation smoothing is on by default to be compatible > with previous behavior. The user can now specify the "noSmoothing" > option to the reader to use facet normals for verticies where the OBJ > file does not specify a normal. > > The patch was tested with the included "boxes.obj" file and proprietary > geometry. In the "boxes.obj" file the red cube does not have normals > specified for the verticies. > > The first test replicates the previous behavior: > % osgconv boxes.obj boxes_smooth.osg > > The second test demonstrates the new capability: > % osgconv -O noSmoothing boxes.obj boxes_sharp.osg > > The two image files depict the results of each conversion. > > Lee Butler > The sender of the message sent the following files that are not allowed by > NETCOM guidance 2004-11A: > None > > In accordance with NETCOM guidance 2004-11A, > AKO has begun stripping files with the following extensions: > .ace, .ad, .ade, .adp, .asp, .b64, .bas, .bat, .bhx, .ceo, > .ce0, .chm, .com, .cmd, .cpl, .crt, .dbx, .dll, .dot, .eml, .exe, > .hlp, .hqx, .hta, .inf, .ins, .js, .jse, .lnk, .mdb, .mde, .mim, .msi, > .msp, .nch, .ocx, .pi, .pif, .rar, .reg, .scr, .sct, .shb, .shs, .upx, > .uue, .uu, .vbe, .vbs, .vss, .vst, .vsw, .wmi, .ws, .wsc, .wsf, > .wsh, .xxe, and .zip. > > Since this is an Army policy, AKO will not be able to grant exceptions. > > You may view the NETCOM guidance at https://www.us.army.mil/suite/doc/7190255 > > The guidance includes instructions on how the sender should send the files > that are restricted. > > Attachment dropped due to NETCOM 2004-11A restrictions. For information on > the attachment dropped, please scroll to the bottom of the mail message. > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
