Hi Chris, I have just reviewed the your suffix change and I'm not sure I quite get why you need it.
The PagedLOD's DatabasePath member is required to make sure that path that a tile is loaded from at runtime it recorded so that it's children can be found, this DatabasePath is set on load of the node so is actively used. This contrasts your new DatabaseSuffix change, it's not recorded or set anywhere in the OSG, so I can only assume it's your app that is setting, and if so then why not just append the suffix to the childrens filenames directly? Also if this appending of the suffix is something done dynamically then the route I would take is to write a custom Registry::ReadFileCallback that intercepts all readNodeFile() etc calls and then adds the suffix there. Such a callback avoids the need to modify the scene graph at all so will be easier to implement and more more efficient. Given that I feel that your changes tackle a problem in way that I would recommend I don't feel it's appropriate to merge them as they just add complexity to the implementation for little or no value add, and in fact may just confuse users into tackle things in a less optimal way. Robert. On Thu, Aug 20, 2009 at 6:51 PM, Chris 'Xenon' Hanson <[email protected]> wrote: > The attached modifications allow for the specification of a suffix to be > applied when > loading the children of a PagedLOD or ProxyNode. This allows widespread > propagation of a > pseudoloader suffix (.myloadername). > > I have tested it with PagedLOD, and migrated the changes to ProxyNode. > ProxyNode > compiles, but since I have no databases using ProxyNode (much less ProxyNode > with a > pseudoloader suffix) I have no way to test the changes there. > > -- > Chris 'Xenon' Hanson, omo sanza lettere Xenon AlphaPixel.com > PixelSense Landsat processing now available! http://www.alphapixel.com/demos/ > "There is no Truth. There is only Perception. To Perceive is to Exist." - Xen > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
