Thanks Jan, fix now merged and submitted to snv/trunk.
On Thu, Nov 19, 2009 at 9:58 PM, Jan Ciger <[email protected]> wrote: > Robert Osfield <[email protected]> wrote: >> Hi Jan, >> >> I resorted to getting OpenVRML 0.18.3 to build under a Kubuntu 9.10 >> install, using this I came across a build issue with your changes - >> you missed sending your changes to ReaderWriterVRML2.h for the change >> in method signature of the convertFromVRML method. I was able to work >> out what this change should have been - simple use what you used in >> the .cpp, and got things to build cleanly. > > That's actually weird, because the only change I have made was removal of a > header file that is not in 0.18.3 anymore. Odd ... I guess something had to > fall through the cracks somewhere. > >> I also fixed an unused >> variable warning : >> >> home/robert/OpenSceneGraph/src/osgPlugins/vrml/IndexedFaceSet.cpp:21: >> warning: unused variable ‘osg_stateset’ >> >> Which... was getOrCreateStateSet(), but I presume isn't required. > > Yes, I think I remember seeing this one, it was a leftover. > >> >> All these changes are now checked into svn/trunk. Could you test out >> svn/trunk to make sure that my changes are all appropriate. > > It works for me (32bit Linux), except for one missed function declaration in > the header that causes undefined symbol crash at runtime. I have just > commented > it out, the file is attached. I am not sure where did the declaration with the > istream as input argument come from. > > Regards, > > Jan > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
