Thanks Chris, I believe your changes are spot on, the readNodeFiles(std::vector<std::string>&) isn't a command line parsers, but an read call that handles vector of filenames so it isn't appropriate to put command line treatment in there - the correct place for this is in readNodeFiles(ArgunmentParse&) function. Changes now merged and submitted to svn/trunk.
On Thu, Oct 22, 2009 at 5:51 PM, Chris 'Xenon' Hanson <[email protected]> wrote: > Remove vestigial (and because it was undocumented, potentially harmful) code > to ignore > filenames starting with a dash "-" character from the > (std::vector<std::string>&) version > of osgDB::readNodeFiles. Handling of argument strings is properly implemented > in the > osgDB::readNodeFiles(osg::ArgumentParser& arguments,const Options* options) > variant, which most code uses. The (std::vector<std::string>&) version is > only called by > the osgconv utility, which does its own argument handling and stripping prior > to calling > readNodeFiles(). > > Also, documented this behaviour in the header comments. > > I believe this code removal is a meritful change because leavign the code in > causes an > unexpected and undocumented behaviour (ignoring any filename starting with a > dash) that > could bite users in the future. This behaviour is not needed for existing > functionality > because existing code uses other APIs to handle dash-prefixed arguments > anyway. > > -- > Chris 'Xenon' Hanson, omo sanza lettere Xenon AlphaPixel.com > PixelSense Landsat processing now available! http://www.alphapixel.com/demos/ > "There is no Truth. There is only Perception. To Perceive is to Exist." - Xen > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
