Robert Osfield wrote: > I'm just reviewing your changes to the .ive plugin and believe the > follow code has a bug in it - the last name where the filename string > is written out is wrong:
I believe you are correct. > I'll be merging this on the assumption that my version is more > appropriate, let me know if I've missed something. My test case didn't encounter this situation, so I had (and have) no way to test it, but I see the error and agree your code fixes it. > Another issue that was introduced is that you've > ReaderWriterIVE::write*(*, istream&..) methods so that they now have a > string& filename. This breaks the .ive's plugin ability to handle > reading from istreams (including http supported) as these methods > should be straight overriding of the virtual methods provided by the > base ReaderWriter class. > The way we've tackled adding details of the filename of the original > file to the istream methods has been to add the filename into the > Options object and then extract this. The .curl plugin does this I > will have a bash at working in such an approach to this code. Hmm. I see. I wasn't aware of this constraint. It does complicate the matter quite a bit. If there's anything you want me to do with this, let me know, otherwise I'll defer to your work. Thanks for integrating this. > Robert. -- Chris 'Xenon' Hanson, omo sanza lettere Xenon AlphaPixel.com PixelSense Landsat processing now available! http://www.alphapixel.com/demos/ "There is no Truth. There is only Perception. To Perceive is to Exist." - Xen _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
