Hi Rob, Changes all look good. I've tweak the change to the .ive Texture.cpp so that it uses the version 43 rather than 38 and bumped the latest .ive rev number to 43, as the .ive plugin has obviously marched on a bit since you made your changes.
Changes now merged and submitted to svn/trunk. Cheers, Robert. On Wed, Jan 6, 2010 at 6:23 PM, Rob Radtke <[email protected]> wrote: > Hi, > I have been using OSG for about a year now and have been very impressed with > it--thank you all for all the hard work you have put into it. > > I recently ran into some issues trying to save/load a scene graph as a .ive > file. The problems came about because the scene graph contained depth > textures in it. I have attached a patch (against the current revision: > 10919) that fixes the issues that I encountered. Both attachments contain > the same patch--one is a .zip file that contains the modified files and the > other is a text patch file. Here is a summary of the changes I made: > > 1) Add getShadowComparison() accessor function to osg::Texture class > 2) Modify ReaderWriterTiff::writeTifStream() and _readColor() (in Image.cpp) > to handle pixelFormat==GL_DEPTH_COMPONENT as if it were GL_LUMINANCE > 3) Modify the Texture classes of the ive and osg plug-ins so that they > save/load the following Texture members: _use_shadow_comparison, > _shadow_compare_func and _shadow_texture_mode > > I am looking forward to working with you to get these changes incorporated > into the main OSG repository. > > Thank you, > Rob > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=22177#22177 > > > > > Attachments: > http://forum.openscenegraph.org//files/osgpatchagainstrevision_10919patch_797.txt > http://forum.openscenegraph.org//files/osg_patchagainstrevision_10919_175.zip > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
