Thanks Jan, changes look good, now all merged and submitted to svn/trunk.
On Sat, Jan 30, 2010 at 3:54 PM, PCJohn <[email protected]> wrote: > Hi Robert, > please, update the code as follows: > > // SoVRMLImageTexture > if (node->isOfType(SoVRMLImageTexture::getClassTypeId())) { > > // Check whether texturing was enabled by the texture node > SoVRMLImageTexture *t = (SoVRMLImageTexture*)node; > texturingEnabled = t->url.getNum() > 1 || > (t->url.getNum() == 1 && t->url[0].getLength() > > 0); > } > > I tested the code on one model and it works well for me. > Let me know about any other problems. Cheers, > John > > > Robert Osfield wrote: >> >> Hi John, >> >> I'm getting the following warning when building the plugin: >> >> >> home/robert/OpenSceneGraph/src/osgPlugins/Inventor/ConvertFromInventor.cpp: >> In static member function ‘static SoCallbackAction::Response >> ConvertFromInventor::postTexture(void*, SoCallbackAction*, const >> SoNode*)’: >> >> /home/robert/OpenSceneGraph/src/osgPlugins/Inventor/ConvertFromInventor.cpp:1021: >> warning: suggest brackets around && within || >> >> >> The line is: >> >> texturingEnabled = (t->url.getNum() > 1 || t->url.getNum() == >> 1 && t->url.getValues(0)[0].getLength() > 0); >> >> >> >> Clearly I need to add a () but I'm not 100% clear on whether it should >> be around the first || or the second && comparison. >> >> Could you please clarify? >> >> Cheers, >> Robert. >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
