Hi Paul, Apologies for time taken to reviewing this submission. Slowly getting through my email back log...
Your changes look spot on, I can only think that the erroneous code was added at some point to handle the case of multiple parents of the transform, but this actual code was nonesensical and unnecessary, especially given that the actual code for adding the new group to the multiple parents is handled right after this. Perplexing indeed. As well as merging your changes and add the copying of UserData and Descriptions from the outgoing Transform to the new Group. An svn update will get all these changes. Cheers, Robert. On Tue, Jan 26, 2010 at 3:09 AM, Paul Martz <[email protected]> wrote: > Hi Robert -- Regarding the osg-users thread "mergeGeodes crash", I'm > submitting this for consideration as a fix for the problem with the > FlattenStaticTransformsVisitor. It seems that the additional nested loop > over the Transform's parent was not needed. I'm not sure why it was there, > and if it really was unnecessary, then it has probably been resulting in > many redundant Nodes for quite some time. Perhaps this fix will result in a > cull- and draw-time performance boost. > > I looked into the MergeGeodes issue but I can't recommend a fix at this > time. I'm hoping you can help with that. More info in the osg-users thread. > -- >
_______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
