Thanks Alok, changes all look sound, now merged and checked into svn/trunk. Cheers, Robert.
On Thu, Apr 22, 2010 at 1:34 PM, Alok Priyadarshi <[email protected]> wrote: > Attached zip file contains modified files. > > Summary of changes in src/OpenThreads/win32: > 1. Moved the definition of WIN32_LEAN_AND_MEAN and _WIN32_WINNT to > vcproj so that they need not be repeated everywhere. > 2. Removed _WINDOWS_ guard before including windows.h. > 3. Removed a few unnecessary inclusions of windows.h > 4. Removed the declaration of Producer::Condition. I think (?) it is > not used anymore > > Summary of changes in src/osg: > 1. Added #ifndef guard for WIN32_LEAN_AND_MEAN. Many third-party > projects compile with this flag and this causes numerous compile > warnings. > 2. Added TEXT() macro for string literals so osg can be compiled with > UNICODE setting. > > > On Wed, Apr 21, 2010 at 9:31 AM, Robert Osfield > <[email protected]> wrote: >> Hi Alok, >> >> On Wed, Apr 21, 2010 at 2:07 PM, Alok Priyadarshi <[email protected]> wrote: >>> Thanks for pointing me to the protocol. My patch spans a few >>> directories so if I send the whole file, should I maintain the >>> directory structure for the modified files? >> >> The ideal way to deliver the changes is by arranging them in the same >> directory structure that they are in when they are part of the >> OpenSceneGraph source tree and zip/tar.gz this into a single package. >> I use a script to run through the changed files in the directories so >> it's very easy for me to do the graphical review of all the files. >> >> You can also just put all the files together into a single zip/tar.gz >> file, I can normally work out which files belong where just from my >> knowledge of the OSG. >> >> Cheers, >> Robert. >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
