HI Sukender, I've just started the review but the UTF8 changes feel like they should be centralized into a single method/function rather than have the #ifdef #else #endif blocks placed across several files. Could you possible create a single function that converts the filename and have it's implementation do the #ifdef #else #endif.
Thanks, Robert. On Fri, Apr 23, 2010 at 10:46 AM, Sukender <[email protected]> wrote: > Hi Robert, > > It's been a while since I wanted to submit our DAE, but I've been delayed by > bugs and by the size of my to-do list... > Changes are on rev. 11367. > > - Added support for reading and writing double precision vertices, normals, > colors, and texcoords. > - Added support for non-ASCII characters by converting them to UTF8, as FBX > readerwriter does. > - Cleaned minor things. > - WARNING! Renamed some options (they were all introduced by my previous > submission, and they are recent): > - DaeEarthTex => daeEarthTex > - ZUpAxis => daeZUpAxis > - ForceTexture => daeForceTexture > I would like to rename other options the same way (prefixed with the plugin > name) but they were not created by me, and I don't want to break > compatibility. Moreover, I guess this should be done once and for all, with > all plugins at the same time, don't you think? > > As there are quite important changes, there is a probabilty that bugs were > introduced. The code has been somewhat tested of course, but be careful. > > Happy merging! > > Sukender > PVLE - Lightweight cross-platform game engine - http://pvle.sourceforge.net/ > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
