I've just reviewed your code change and it's far less readable than
the original code so I see this as a step backwards for
maintainability.  Ulrich's suggestion of using std::string is
reasonable, and looking at online usage of xine_config_load it looks
like this method doesn't assume control of it and delete it, rather it
leaves it up to the calling code.  I've modified the code to look
like...

Hi Robert and Ulrich,

Thanks for the discussion and helping us out with building OSG in mingw-cross-env.

The solution using std::string is indeed more concise. If the opportunity comes up again, I'll remember that. Good point about exception safety Ulrich.

regards,

Mark

_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to