Hi Alok, Thanks fort the changes. I've dived in a done a review of the changes and have gone ahead and merged the APIENTTRY to GL_APIENTRY changes. These are now checked into svn/trunk.
I don't feel the GLES2StaticLibrary class is quite right as it stands. First up I see this as an internal implementation details rather than an public interface so there shouldn't be able class or functions in the include/osg directory, all the implementation should be kept private in the src/osg implementation directory. I'm reasonably comfortable with the general approach of having a helper class, but it's just a case of getting the implementation right. I also don't see the static GL library as just a GLES2 issue, so rather than merge the CMake changes that just reference GLES2 I've checked in a general OSG_GL_LIBRARY_STATIC variable and associated #define, this leaves the door open to static versions of any of the GL libs. I think the next step would be to implement the GLESStaticLibrary function mapping as an std::map<> as it will make the implement more straight forward and easier to maintain, and we can also easily extend it so the contents of the std::map<> are provided for different static GL/GLES targets. One thing we'll need to be mindful of is the thread safety of initialization the std::map. Cheers, Robert. On Wed, Apr 28, 2010 at 8:55 PM, Alok Priyadarshi <[email protected]> wrote: > Hi Robert, > > I have attached my changes to statically link gles2 lib. There are two > main changes: > 1. Replaced APIENTRY to GL_APIENTRY which is used by OpenGL ES > headers. For desktop GL GL_APIENTRY has been defined as APIENTRY. > 2. Added GLES2StaticLibrary class that provides proc-address lookup > given a proc name. > > Not perfect, but this is the least intrusive option I could think of. > > Thanks, > -Alok > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
