Hi Wang Rui,

On Mon, Jun 21, 2010 at 4:17 PM, Wang Rui <[email protected]> wrote:
> Hi Robert,
> I believe that your changes of the osgTerrain serializer should be OK, and
> more readable. But for the use of VPB under Windows, the
> DatabaseBuilderIO.cpp seems to require modifications too, including the
> following lines:
> // I'm not sure why the std::binary is required here, but it simply fails
> without that flag on my VS2008 and Windows XP.
> std::ifstream fin(fileName.c_str(), std::ios::in|std::ios::binary);
> // It's OK not to add this line, I think
> local_opt->setOptionString( local_opt->getOptionString() + " Ascii" );
> Otherwise vpbmaster will fail to load .source files in ascii mode and read
> from streams properly. I don't know if it is a Windows stream I/O issue. But
> I would like to have a test on another machine tomorrow and we could also
> see if the community will help in depth.

I had merged this change, but not checked it in.  Thanks for the
reminder, I've now gone ahead and checked this fix into VPB svn/trunk.

Thanks for the review of my changes.

Cheers
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to