Hi Vivien, Third new contributor this morning, looks like we've got a hatrick!
I've had to go a bit of chase to get the files due to forum messing not quite passing links to them with the proper file names, in the end I was able to work out what is what. Clearly we need to address this, but this is something for another day. An easy way round this issue would be use a single zip file, or just use mailing list for submissions. On the topic of the submission, the changes look reasonable but I'm not Windows users let alone expert so I'll have to defer to windows dev's like yourself, hopefully other Windows devs will be able to vet these changes as well. For now I'm happy to assume the changes will work across all Windows variants and usage models and have checked the changes in. Thanks, Robert. On Wed, Aug 18, 2010 at 2:13 AM, Vivien Delage <[email protected]> wrote: > Hi, > > I am sorry I did not know about this submission protocol. > Attached is the header and .cpp of the class GraphicsWindowWin32. > > > By the way, I figured out that their could be a conflict between the unicode > input that I return and your way of encoding the special keys. You are using > a the range 0xff00 for the special keys but this range could also be used by > the unicode which is encoded in utf16. > > I think a better way would be to create a separate event for unicode user > input. This way there would not be any conflicts: > - keep the key press / key release event as it was. Those events would be > used by manipulators or games for example. > - create a new event type "unicode user input" that would be fired only at > key press. This event could be used by GUIs to find out what the user entered. > > Other libs like SDL are doing such separation and I think it makes sense. > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=30861#30861 > > > > > Attachments: > http://forum.openscenegraph.org//files/graphicswindowwin32_128.cpp > http://forum.openscenegraph.org//files/1475_1282093202._123. > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
