Hi JS,

I'm just diving into this submission and have got a compiler warning:

/home/robert/OpenSceneGraph/src/osgWidget/Input.cpp: In member
function ‘virtual bool osgWidget::Input::mouseDrag(double, double,
const osgWidget::WindowManager*)’:
/home/robert/OpenSceneGraph/src/osgWidget/Input.cpp:297: warning:
suggest brackets around && within ||
/home/robert/OpenSceneGraph/src/osgWidget/Input.cpp: In member
function ‘virtual bool osgWidget::Input::mousePush(double, double,
const osgWidget::WindowManager*)’:
/home/robert/OpenSceneGraph/src/osgWidget/Input.cpp:325: warning:
suggest brackets around && within ||

The offending code is:

        if (x >= offset1 && x <= offset2 ||
            i == _offsets.size() - 1)  // If we're at the last one,
obviously it will be there.

Which I'd guess should read something like:

        if ( (x >= offset1 && x <= offset2) ||
            i == _offsets.size() - 1)  // If we're at the last one,
obviously it will be there.

Is this correct?

Cheers,
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to