Hi Robert,
I don't think a warning would be appropriate as it'd be reported even
when users won't have an app that will see any problems without the
feature being enabled.
I personally think that for the amount of development work involved, the
warning David suggested is good enough. If the user will run into a case
that requires locks, they should know it. If not, they can safely ignore
the warning.
The warning could be rephrased as:
"ffmpeg before version 0.5.1 is not thread safe. Your version of ffmpeg
may have trouble if you try to load multiple streams in parallel. If not
you may safely ignore this warning."
The warning could even be disabled explicitly with an Option string like
disable_ffmpeg_threadsafe_warning, if the user knows they are using an
ffmpeg version without av_lockmgr but it doesn't cause problems for them.
Anyways, at this point the fix is in, I just wanted to make sure that
the code was not just silently disabled when compiling against an older
version of ffmpeg, as there's clearly value in the fix in some usage
scenarios otherwise it wouldn't have been necessary to commit it :-)
If no engineer has any time to code up a more intelligent solution, I
say the warning is good enough, and certainly better than silently
disabling the code, but it's your call.
Thanks,
J-S
--
______________________________________________________
Jean-Sebastien Guay [email protected]
http://www.cm-labs.com/
http://whitestar02.webhop.org/
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
