Thanks Wang Rui, these name changes make the code clearer and more understandable, changes now merged and submitted to svn/trunk. Cheers, Robert.
On Wed, Sep 15, 2010 at 3:15 AM, Wang Rui <[email protected]> wrote: > Hi Robert, > I made a quick submission to fix these weird code: > 2010/9/14 Robert Osfield [email protected] >> >> 1) The use of a Vec3 _base_prop in osgParticle for storing various >> state variables >> and then accessing/setting it via .x()/,y() etc. Either >> separate variables or >> accessing a vector through the [] accessor an enum for the entry >> into it might >> be more clear about it's function. >> > I've changed it back to _alive, _current_size and _current_alpha, and placed > them one by one for setTexCoordPointer() to use. > >> >> 2) The method name size() makes one think of std::vector::size(), which >> could >> be a little confusing if your reading the code quickly. >> > > > All size() methods are now renamed to volume(). At present only the > CompositePlacer will use it for randomly choose a place according to the > volumes of all children. > > My next plan of the osgParticle library is to consider using GPGPU for > computing particle positions and velocities on the fly. Also there should be > a few existing and newcoming bugs to fix. I'll be ready for suggestions and > bug reports all the time. :) > > Cheers, > > Wang Rui > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
