Thanks for the explanation and resolution Paul, change now merged and submitted to snv/trunk. Cheers, Robert.
On Thu, Sep 9, 2010 at 3:29 PM, Paul de Repentigny <[email protected]> wrote: > Hi Robert, > > That section of the code you are talking about was an attempt to order the > vertices of a triangle or quad array so that it appears correctly with > backface culling on. AFAIK, it doesn't work as intended and should commented > in, or left as an exercise for anyone willing to tackle the job. > > > > > Regards, > > Paul de Repentigny > > On 09-09-10, at 06:24, Robert Osfield wrote: > >> Hi Joachim, >> >> I've just do the review and what a curious code error you have fixed, >> I can only assume the original author got confused about the ordering >> of the increment with iterator having been already incremented before >> the loop and the need to increment it again. You interpretation of >> the code looks appropriate, but I'm a little uneasy about exactly what >> the original author intended - I think it's what you have implemented, >> and it'll certainly solve the crash. It would be nice for the >> original author to have a look over the changes - there has been 7 >> different engineers tinkering with the code so I'm not sure who is >> responsible, svn would probably pinpoint it, but right now I have too >> many submissions to chase up to warrant satisfying my curiosity and >> wish to double check everything. >> >> Cheers, >> Robert. >> >> On Wed, Aug 18, 2010 at 1:11 PM, Pouderoux Joachim <[email protected]> >> wrote: >>> Hi, >>> >>> Please find attached a very small fix for the DXF reader. The bug made OSG >>> crash with some files. >>> Actually, itr was incremented into the loop and after the test with >>> nlist.end(). >>> Then, the unreferencing of itr when nlist is equals to nlist.end() caused >>> the crash. >>> >>> Cheers, >>> >>> Joachim >>> >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>> >>> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
