Hi JS, I'm wait until after the 2.9.9 dev release before merging as I'm not want to risk any regressions.
Cheers, Robert. On Thu, Sep 16, 2010 at 3:49 PM, Jean-Sébastien Guay <[email protected]> wrote: > Hi Robert, > >> I applied your changes but then when I ran even something simple like >> osgviewer cow.osg I got an seg fault, with what looks like a recursive >> loop in the findFileInPath code. I haven't dived in to see why this >> might be occurring, but since your the author I though perhaps the >> code hasn't been tested well enough yet, perhaps there is a platform >> portability issue that you've introduced. Either way, as it the >> submission isn't in a shape to merge yet. > > Sorry, I realized that my change to isFileNameNativeStyle() was braindead. > The logic was reversed, and it would return false if the path contained no > separators at all, on all platforms... This would indeed lead to an infinite > loop in findFileInPath() for cow.osg, because of this: > > if (!isFileNameNativeStyle(filename)) > return findFileInPath(convertFileNameToNativeStyle(filename), > filepath, caseSensitivity); > > Sorry about this. I've introduced getUnixPathSeparator() and > getWindowsPathSeparator() and fixed isFileNameNativeStyle(). Please give the > attached files a try. All other files from the original submission > (FileUtils header and cpp, and osgvolume.cpp) are still good. > > Thanks, > > J-S > -- > ______________________________________________________ > Jean-Sebastien Guay [email protected] > http://www.cm-labs.com/ > http://whitestar02.webhop.org/ > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
