Thanks Ulrich, changes merged and submitted to svn/trunk.
On Sat, Sep 18, 2010 at 7:08 AM, Ulrich Hertlein <[email protected]> wrote: > Hi Robert, > > attached is a fix that addresses these compiler warnings from the 64-bit OS X > build: > > /Users/uli/Projects/osg/OpenSceneGraph/src/osgPlugins/3ds/WriterNodeVisitor.cpp: > In > function ‘std::string getFileName(const std::string&)’: > /Users/uli/Projects/osg/OpenSceneGraph/src/osgPlugins/3ds/WriterNodeVisitor.cpp:88: > warning: comparison is always false due to limited range of data type > > /Users/uli/Projects/osg/OpenSceneGraph/src/osgPlugins/3ds/WriterNodeVisitor.cpp: > In > function ‘bool is83(const std::string&)’: > /Users/uli/Projects/osg/OpenSceneGraph/src/osgPlugins/3ds/WriterNodeVisitor.cpp:102: > warning: comparison is always false due to limited range of data type > > /Users/uli/Projects/osg/OpenSceneGraph/src/osgPlugins/3ds/WriterNodeVisitor.cpp: > In > function ‘bool is3DSpath(const std::string&, bool)’: > /Users/uli/Projects/osg/OpenSceneGraph/src/osgPlugins/3ds/WriterNodeVisitor.cpp:118: > warning: comparison is always false due to limited range of data type > /Users/uli/Projects/osg/OpenSceneGraph/src/osgPlugins/3ds/WriterNodeVisitor.cpp:121: > warning: comparison is always true due to limited range of data type > > The code was using 'unsigned int' in places where it should've used 'size_t' > for correct > comparison with 'std::string::npos' (which is size_t). > > Cheers, > /ulrich > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
