Thanks Sukender, fix now merged and submitted to svn/trunk.
On Tue, Oct 5, 2010 at 11:52 AM, Sukender <[email protected]> wrote: > Hi Ulrich and Robert, > > Errr... I certainly wrote == instead of != ... > Here is the file. > > Sukender > PVLE - Lightweight cross-platform game engine - http://pvle.sourceforge.net/ > > ----- "Ulrich Hertlein" <[email protected]> a écrit : > >> Hi guys, >> >> while fixing compiler warnings for the OS X build I noticed this bit >> in >> osgPlugins/3ds/WriterNodeVisitor.cpp: >> >> <code> >> /// Tests if the given string is a path supported by 3DS format (8.3, >> 63 chars max). >> bool is3DSpath(const std::string & s, bool extendedFilePaths) >> { >> ... >> // For each subdirectory >> size_t tokenLen; >> for (size_t tokenBegin=0, tokenEnd=0; >> tokenEnd == std::string::npos; >> tokenBegin = tokenEnd+1) >> { >> tokenEnd = s.find_first_of("/\\", tokenBegin); >> ... >> } >> return true; >> } >> </code> >> >> The for loop is dead code, since it sets 'tokenEnd=0' and then checks >> for >> 'tokenEnd==std::string::npos' which can never be true. >> >> I don't really want to touch it without knowing in what cases it is >> relevant or being able >> to activate the function. >> >> Could the original author (sukender?) maybe verify this function? >> >> Cheers, >> /ulrich >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
