Hi Robert,

Wow, great that you merged this change, it's something I've wanted to add for a long while now so it's great to see it go in!

Any comments in general on the way I did this? Does it seem to make sense to you, and will it make sense to users?

One thing it's really sensitive about of course is consistency in times. The best way I've found when doing real timing is to use

osg::Timer::instance()->delta_s(view->getStartTick(),
                                osg::Timer::instance()->tick())

to get the correct time at a given point in the program.

I've merged your changes and tested your modified osgviewer example,
and found that while the stats worked, the normal dark gray background
to the stats was not updated correctly, this is pretty obvious when
you run your modified osgviewer so I'll assume you'll be able to see
the problem first hand and fix it.

Ah yes, I fixed this locally but forgot to send the modified file.

I'll also put in a bit more documentation on the added methods in StatsHandler. I'll send this in a little bit.

To help move things along I have merged your changes as it only seems
to be the user stats that causes problems with the alignment of the
dark grey background.  I think it'd be useful to have an example of
user stats in action, would it be possible to simply your modified
osgviewer so it just focuses on the user stats, and then just rename
it to something like osguserstats.  We can then use this as an example
and a testbed.

Agreed, I'll add this and send it with the other changes I mentioned above.

Thanks,

J-S
--
______________________________________________________
Jean-Sebastien Guay    [email protected]
                               http://www.cm-labs.com/
                        http://whitestar02.webhop.org/
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to