Hi Brad, I was worried that the change wouldn't be portable, but was hoping that it was so I'd be able to keep the code simple. On the include front the extra includes I added weren't in the end necessary so I've just removed these completely, and have add in the #ifdef _WIN32 as per your change. These two changes are now checked into svn/trunk.
Cheers, Robert. On Fri, Nov 5, 2010 at 3:13 PM, Brad Christiansen <[email protected]> wrote: > Hi Robert, > > I have just updated osg and vpb from svn (nice accronym usage : ) and vpb no > longer compiles on Windows due to the changes you made in revision 1021 : > Build fix for gcc 4.4.4. > > This added a few includes and changed the line: > vpb::fchmod(_fileID, S_IREAD | S_IWRITE | S_IRGRP | S_IWGRP | S_IROTH | > S_IWOTH); > to > vpb::fchmod(_fileID, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | > S_IWOTH); > > > The attached file reverts the change if _WIN32 if defined. I am pretty sure I > should be checking something else (I think _WIN32 is still defined when using > cygwin for example, but I am guessing your change would be required in this > case) but I am not familiar with cross platform issues like this. If you can > suggest what the guard should be (or point me towards an example) or can > think of a better solution let me know and I will modify the changes and > re-submit. > > Cheers, > Brad > > ... > > > Thank you! > > Cheers, > Brad > > ------------------ > Read this topic online here: > http://forum.openscenegraph.org/viewtopic.php?p=33529#33529 > > > > > Attachments: > http://forum.openscenegraph.org//files/propertyfile_469.cpp > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
