Hi Michael, Good investigative work. I've just merged your change, made a little tweak and checked it into svn/trunk.
The tweak I made was to just make the void Object::setName(const std::string&) virtual and to make void Object::setNane(const char*) inline, with it constructing a std::string and then calling setName(std::string). With this change it's possible to simply the code you added into Uniform. I've tested the changes and osgviewer glsl_julia.osg works once more. Thanks for you help, Robert. On Fri, Nov 26, 2010 at 12:53 PM, Michael Platings <[email protected]> wrote: > The serializer calls Object::setName() which isn't virtual (I mistakenly > assumed it was, apologies) so Uniform::setName() never gets called. > > The attached files make both Object::setNames virtual, and override both in > Uniform. > This fixes both glsl_julia and glsl_mandelbrot > > > On 26 November 2010 11:44, Michael Platings <[email protected]> wrote: >> >> Yes, reverting my change does fix the problem. Working on it now... >> >> On 26 November 2010 10:38, Robert Osfield <[email protected]> >> wrote: >>> >>> Hi Michael, >>> >>> I was testing the OSG using runexamples.bat yesterday and came across >>> a regression in: >>> >>> osgviewer glsl_julia.osg >>> >>> and >>> >>> osgviewer glsl_mandlebrot.osg >>> >>> Both are now rendering as black quads rather than the pretty patterns >>> one would normally expect. I believe this regression will have >>> occurred when merging your changes to Uniform ID's, but as I didn't do >>> the above tests just prior and after I can't 100% confirm this. I do >>> recall both working in the last week or so though so it's a very >>> recent regression, and likely to be down to the new changes for >>> Uniform ID's. My guess is that the plugins set the name differently. >>> >>> Robert. >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
