Hi Brad, I have now merged your changes save for the changes to OutputStream. I made a small tweak to InputStream::readImage(bool) so that it took a default initializater of =true, so that readImage() method could be removed.
Changes now merged and submitted to svn/trunk. Cheers, Robert. On Mon, Jan 10, 2011 at 2:14 AM, Christiansen, Brad <[email protected]> wrote: > Hi, > > I didn't realize you had to force the output of image files with the osg > format. I just assumed it would automatically be done. As such, the current > behavior is probably correct, or at least consistent between .osg and .osgt. > As such, such ignore the 2 line change to OutputStream. > > Cheers, > Brad > > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of > Jean-Sébastien Guay > Sent: Thursday, 6 January 2011 10:20 PM > To: OpenSceneGraph Submissions > Subject: Re: [osg-submissions] Fix for deferred optional layer loading in new > file formats > > Hi Brad, > >> During my testing I also found another bug. If an image has a hint to be >> inlined and is saved using the osgt format then no image was written out. To >> fix the issue I added an extra check to OuputStream to force images to be >> written externally if the stream is not binary. I haven't done a great deal >> of testing for this change and I haven't come across the issue other than in >> experimenting with my deferred loading code. As such, I am not particularly >> confident this is the correct fix but this seems to be a bug that needs to >> be addressed. > > I'm sure you know this, but when writing a .osg file you need to force > it to output image files with the OutputTextureFiles option: > > osgconv someFileWithEmbeddedTextures.ive outputFile.osg -O > "OutputTextureFiles" > > Is this the same thing? Do you always output the image (i.e. as if the > above option was always enabled for the .osg plugin)? Would you need to > check a similar option? > > Just wondering if you're not changing the expected behavior. Thanks, > > J-S > -- > ______________________________________________________ > Jean-Sebastien Guay [email protected] > http://www.cm-labs.com/ > http://whitestar02.webhop.org/ > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > DISCLAIMER:--------------------------------------------------------------------------- > This e-mail transmission and any documents, files and previous e-mail messages > attached to it are private and confidential. They may contain proprietary or > copyright > material or information that is subject to legal professional privilege. They > are for > the use of the intended recipient only. Any unauthorised viewing, use, > disclosure, > copying, alteration, storage or distribution of, or reliance on, this message > is > strictly prohibited. No part may be reproduced, adapted or transmitted > without the > written permission of the owner. If you have received this transmission in > error, or > are not an authorised recipient, please immediately notify the sender by > return email, > delete this message and all copies from your e-mail system, and destroy any > printed > copies. Receipt by anyone other than the intended recipient should not be > deemed a > waiver of any privilege or protection. Thales Australia does not warrant or > represent > that this e-mail or any documents, files and previous e-mail messages > attached are > error or virus free. > -------------------------------------------------------------------------------------- > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
