Hi Michael and Robert, In short: - About daeWMaterials.cpp, Michael is right: DAE writes UTF8, so we convert if we're using codepage. - About osgDB, I must admit the implementation is not the best thing I wrote... So yes, only windows is case insensitive (this should be fixed), and I expect the function to handle both slashes and backslashes, as they were equal.
I won't be working on the osgDB function soon, so feel free to modify. I'll concentrate on DAE (the bug I told when submitting). Any other thing to know? Thank you both for the discussion. Thank you for merging, Robert. Cheers, Sukender PVLE - Lightweight cross-platform game engine - http://pvle.sourceforge.net/ ----- "Michael Platings" <[email protected]> a écrit : > It looks correct to me. My understanding is: > > The Collada DOM uses UTF-8 and assumes that all strings passed to it > will be UTF-8. > > - In the first case (OSG_USE_UTF8_FILENAME is defined) the filename is > already UTF-8, so it can be converted straight to a URI. > - In the second case (OSG_USE_UTF8_FILENAME not defined) the filename > is using the current code page so must first be converted to UTF-8, > then converted to a URI. > > My only suggestion is that this check should be moved into > ConvertFilePathToColladaCompatibleURI itself. > > HTH > > > On 21 January 2011 11:56, Robert Osfield < [email protected] > > wrote: > > > Hi Sukender, > > I have now merged the changes to osgDB with reservations - as we can > come back and fix the case issue later. > > I am currently review the changes to the dae plugin, and have come > across an #ifdef OSG_USE_UTF8_FILENAME block in daeWMaterials.cpp. Is > this block supposed to be there? The #if #else #endif also looks the > wrong way around to me, with the convert to UTF8 in the #else block. > The code is: > > #ifdef OSG_USE_UTF8_FILENAME > fileURI = > ReaderWriterDAE::ConvertFilePathToColladaCompatibleURI(fileURI); > #else > fileURI = > ReaderWriterDAE::ConvertFilePathToColladaCompatibleURI( > osgDB::convertStringFromCurrentCodePageToUTF8(fileURI) ); > #endif > > What is your intention here? > > > > Robert. > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
