Hi Tim
On Fri, Feb 4, 2011 at 11:04 PM, Tim Moore <[email protected]> wrote:
> The non-virtual cloneOptions() method, which is now used by DatabasePager,
> breaks derived classes of osgDB::Options. This patch uses the clone() method
> to clone Options.
Thanks, changes look appropriate now merged and submitted to snv/trunk.
I have also now made the cloneOption a little more flexible and
consistent with the clone() method by adding the copyop parameter
thus:
Options* cloneOptions(const osg::CopyOp&
copyop=osg::CopyOp::SHALLOW_COPY) const { return
static_cast<Options*>(clone(copyop)); }
> By the way, why does the DatabasePager now clone the options object that is
> passed with a request?
The DatabasePager now modifies the Options object to pass in
information about the Terrain node that decorates the subgraph that is
being loaded so has to clone it to ensure thread safety. This is now
directly assigned the TerrainTile on load rather than implicitly
during the first traversal of the scene graph.
Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org