Hi Robert, I understand. This is why I discussed about meta data handling. If I manage to produce "soon" a metadata system, and if you feel that such code is ok for integration, then we'll certainly be able to use it as a basis. We'll see that later :)
Thanks for the integration and comments. Cheers, Sukender PVLE - Lightweight cross-platform game engine - http://pvle.sourceforge.net/ ----- "Robert Osfield" <[email protected]> a écrit : > Hi Sukender, > > Changes merged and submitted to svn/trunk. I've merged all the > changes save for the comment. > > While I agree generally agree with the comment, I don't think the > place for it is there, and the issue raises a wider issue - the const > nature of Options being passed in. If we are modifying the object > then it's obviously not really const so perhaps it shouldn't be > declared as such. Changing the declaration does have knock on > effects. There is also the issue of thread safety, assuming a const > object makes threading easier, otherwise you have to lock access or > duplicate objects for each thread. This is far wider issue than > just dae plugin so we really should start thinking about the issue. > > Unfortunately I'm not in position to do this wider review right now > as > I've got too much on my plate already so it'll have to wait. > > Robert. > > > > On Wed, Feb 9, 2011 at 9:14 AM, Sukender <[email protected]> wrote: > > Hi Robert, > > > > Here are two sumbissions for DAE. > > > > 1. daeRGeometry.cpp (rev 12132). A tiny sumbission which fixes a > quite important bug: a parameter was forgotten in Collada > ReaderWriter, and texture coordinates could not be loaded properly. > So: > > " > > Added missing paramter when calling createGeometryData(). Fixes > missing texture coordinates (in "bind_vertex_input"). > > " > > > > 2. ReaderWriterDAE.cpp (rev 12132): > > " > > Added "baseImageDir" as a plugin string data, in order to manually > specify base directory to use when relativising image file names. This > is used to properly write files, when images are not located in a > subdirectory (like "../images" for some software). > > Also added a comment to warn about writing a const object. > > " > > > > Cheers, > > > > > > Sukender > > PVLE - Lightweight cross-platform game engine - > http://pvle.sourceforge.net/ > > > > _______________________________________________ > > osg-submissions mailing list > > [email protected] > > > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
